Re: [PATCH] progress: don't dereference before checking for NULL
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 10, 2020, 21:57 UTC
- Message-ID
- <xmqqo8nib1ui.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20200810194748.1483784-1-martin.agren@gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
> The progress API handles NULL just fine, but > that's the NULL-ness of `*p_progress`, e.g., when running with > `--no-progress`. If `p_progress` is NULL, chances are that's a mistake.
True, true.
Thanks.