Re: [PATCH] builtin/clone: avoid failure with GIT_DEFAULT_HASH

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 14, 2020, 21:37 UTC
Message-ID: <xmqqo8m811mf.fsf@gitster.c.googlers.com>
In-Reply-To: <20200912195256.GN241078@camp.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 8 quoted lines

>> Alternatively, I certainly wouldn't complain if you did introduce a new
>> function and updated the call-site that passes reinit as 1.
>
> I thought about introducing a new function, but since it would share
> almost all of the code, it seemed a bit wasteful, even if the function
> is small.  We do have only two callers, I believe, since I recall
> making this function non-static and calling it from clone, so I think
> it's okay.

Perhaps.

FWIW, this seems to have strange interaction with something in 'seen' when merged; I suspect it is the topic that mucks with the set-up sequence for "git clone", but didn't check.