Re: [PATCH v2 0/1] And so it begins...merge/rename performance work
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 14, 2021, 19:08 UTC
- Message-ID
- <xmqqo8hrxrnh.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20210113221158.2869128-1-newren@gmail.com>
Elijah Newren <newren@gmail.com> writes:
> This depends on a merge of en/ort-conflict-handling, en/diffcore-rename, > and en/ort-directory-rename.
Thanks.
How ready is the foundation to accept this change? This will depend on all of the above three topics and I am not sure what the status of them is---I think that I've read through the diffcore-rename one and it was a pleasant read, but I do not recall the reviewer reactions to the other two.
It does not instill a lot of confidence in these topics that nobody commented on things like [v2 17/17] of en/ort-directory-rename (which fixes the code introduced in [v2 06/17] instead of fixing it at the source before 06/17 copies it from elsewhere [*1*]). It looks to me like a sign that these collection of series are moving too fast than any reviewer to catch up.
Thanks.
[Footnote]
*1* I do not particularly think [06/17] that copies and leaves the
recursive backend behind is necessarily bad. What I find more
disturbing is that nobody seems to have a chance to give any
look to the two iterations of the series (as far as I can see,
v2 is just in name only---it removed 18/17 in v1 that were not
meant to be sent), and we are about to build on top of the
foundation that nobody knows how solid it is.