git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/1] And so it begins...merge/rename performance work

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 14, 2021, 19:08 UTC
Message-ID
<xmqqo8hrxrnh.fsf@gitster.c.googlers.com>
In-Reply-To
<20210113221158.2869128-1-newren@gmail.com>
Elijah Newren <newren@gmail.com> writes:
> This depends on a merge of en/ort-conflict-handling, en/diffcore-rename,
> and en/ort-directory-rename.
Thanks.

How ready is the foundation to accept this change? This will depend on all of the above three topics and I am not sure what the status of them is---I think that I've read through the diffcore-rename one and it was a pleasant read, but I do not recall the reviewer reactions to the other two.

It does not instill a lot of confidence in these topics that nobody commented on things like [v2 17/17] of en/ort-directory-rename (which fixes the code introduced in [v2 06/17] instead of fixing it at the source before 06/17 copies it from elsewhere [*1*]). It looks to me like a sign that these collection of series are moving too fast than any reviewer to catch up.

Thanks.
[Footnote]
*1* I do not particularly think [06/17] that copies and leaves the
    recursive backend behind is necessarily bad.  What I find more
    disturbing is that nobody seems to have a chance to give any
    look to the two iterations of the series (as far as I can see,
    v2 is just in name only---it removed 18/17 in v1 that were not
    meant to be sent), and we are about to build on top of the
    foundation that nobody knows how solid it is.
Previous: Elijah NewrenNext: Elijah Newren
Message 9 of 17 in “And so it begins...merge/rename performance work”
  1. 0/1 And so it begins...merge/rename performance workElijah Newren, Jan 8, 2021
  2. 1/1 merge-ort: begin performance work; instrument with trace2_region_* callsElijah Newren, Jan 8, 2021
  3. Taylor BlauJan 8, 2021
  4. Elijah NewrenJan 8, 2021
  5. Taylor BlauJan 8, 2021
  6. Elijah NewrenJan 9, 2021
  7. 0/1 And so it begins...merge/rename performance workElijah Newren, Jan 13, 2021
  8. 1/1 merge-ort: begin performance work; instrument with trace2_region_* callsElijah Newren, Jan 13, 2021
  9. Junio C HamanoJan 14, 2021
  10. Elijah NewrenJan 14, 2021
  11. 0/1 And so it begins...merge/rename performance workElijah Newren, Jan 15, 2021
  12. 1/1 merge-ort: begin performance work; instrument with trace2_region_* callsElijah Newren, Jan 15, 2021
  13. 0/3 And so it begins...merge/rename performance workElijah Newren, Jan 24, 2021
  14. 2/3 merge-ort: ignore the directory rename split conflict for nowElijah Newren, Jan 24, 2021
  15. 1/3 merge-ort: fix massive leakElijah Newren, Jan 24, 2021
  16. Derrick StoleeJan 24, 2021
  17. 3/3 merge-ort: begin performance work; instrument with trace2_region_* callsElijah Newren, Jan 24, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.