git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] multi-pack-index: fix --object-dir from outside repo

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 23, 2021, 08:05 UTC
Message-ID
<xmqqo89osi0b.fsf@gitster.g>
In-Reply-To
<4d65ef5b0a9e4104d763facc42d10a20557d054d.camel@sipsolutions.net>
Johannes Berg <johannes@sipsolutions.net> writes:
Show 10 quoted lines
> I just needed to go outside the current test git directory, the tests
> are running in a way that the current working directory is already the
> git tree I'm operating in.
>
>> Even if you mean to use "cd",
>> please do so within a sub-shell.
>
> I thought about it, but clearly all the tests are run in a sub-shell, so
> it didn't seem necessary? But happy to change, I don't really care
> either way.
Please learn to care before you write your next test, then ;-)

These tests are not run in a sub-shell; they are eval'ed, so that the assignment they make to variables can persist and affect the next test piece.

Thanks.
Previous: Johannes BergNext: Johannes Berg
Message 4 of 11 in “multi-pack-index: fix --object-dir from outside repo”
  1. multi-pack-index: fix --object-dir from outside repoJohannes Berg, Aug 20, 2021
  2. Derrick StoleeAug 22, 2021
  3. Johannes BergAug 23, 2021
  4. Junio C HamanoAug 23, 2021
  5. Johannes BergAug 23, 2021
  6. Derrick StoleeAug 23, 2021
  7. Johannes BergAug 23, 2021
  8. Junio C HamanoAug 23, 2021
  9. Junio C HamanoAug 23, 2021
  10. Taylor BlauAug 23, 2021
  11. Johannes BergAug 23, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.