Re: en/present-despite-skipped (Re: What's cooking in git.git (Feb 2022, #05; Thu, 17))

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 23, 2022, 19:39 UTC
Message-ID: <xmqqo82xv0cj.fsf@gitster.g>
In-Reply-To: <YhV3KruSTFYEDBAO@google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 11 quoted lines

>>>  Will merge to 'master'.
>>>  cf. <20220204081336.3194538-1-newren@gmail.com>
>>>  source: <pull.1114.v2.git.1642175983.gitgitgadget@gmail.com>
>>
>> I'd recommend holding off on merging to 'master' for now, until we
>> figure out what to do about
>> https://lore.kernel.org/git/YhBCsg2DCEd9FXjE@google.com/. Hopefully that
>> won't take long.
>
> Since as discussed there this isn't a regression for existing users of
> git 'master', I see no reason to hold off on merging to 'master'.

I think I've read on what people said on this topic for the past few days while I was away.

I do not quite follow the above, though.

Does the logic go like this?

 - Earlier you worried that VFS for Git and similar that have been
   working happily with vanilla Git would break with this series;

 - It turns out that VFS for Git comes with its own version of Git
   that does not have this series;

 - Hence we can do whatever we like to vanilla Git, and it won't
   immediately hurt.

The config knob to tell the sparse logic that it is OK if lstat() tells us that there appears files that ought to be missing from the filesystem due to sparse settings would be needed and that is why you sent an updated proposal patch in separate thread, right?

Shouldn't we iron out the details of that knob and release the topic with that knob at the same time? If Microsoft folks already have an existing knob to tweak the behaviour of sparse checkout to work better in vfs environment where lstat() lies, and if the necessary adjustment is wider than just the issue the sparse.expectFilesOutsideOfPatterns solves, I wonder if we should take the approach to align with their forked version of Git by matching the name and the behaviour of the knob somehow.

Thanks.