Re: [PATCH 2/3] t3701: test the built-in `add -i` regardless of NO_PERL
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 30, 2022, 19:09 UTC
- Message-ID
- <xmqqo7w1k0ph.fsf@gitster.g>
- In-Reply-To
- <54d25d991b09219f6992dc3e8c102ce1ccef6313.1661867664.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 9 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de> > > The built-in `git add --interactive` does not require Perl, therefore we > can safely run these tests even when building with `NO_PERL=LetsDoThat`. > > Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> > --- > t/t3701-add-interactive.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
A companion to the previous step that is obvious and very much to the point. Looking good.
Show 15 quoted lines
> diff --git a/t/t3701-add-interactive.sh b/t/t3701-add-interactive.sh > index b354fb39de8..8d16cd45821 100755 > --- a/t/t3701-add-interactive.sh > +++ b/t/t3701-add-interactive.sh > @@ -7,9 +7,9 @@ export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME > . ./test-lib.sh > . "$TEST_DIRECTORY"/lib-terminal.sh > > -if ! test_have_prereq PERL > +if test_have_prereq !ADD_I_USE_BUILTIN,!PERL > then > - skip_all='skipping add -i tests, perl not available' > + skip_all='skipping add -i (scripted) tests, perl not available' > test_done > fi