Re: [PATCH v2] credential/wincred: store password_expiry_utc

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 30, 2023, 19:19 UTC
Message-ID: <xmqqo7oahws8.fsf@gitster.g>
In-Reply-To: <pull.1477.v2.git.git.1680200278780.gitgitgadget@gmail.com>

"M Hickford via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines

> From: M Hickford <mirth.hickford@gmail.com>
>
> This attribute is important when storing OAuth credentials which may
> expire after as little as one hour. See
> https://github.com/git/git/commit/d208bfdfef97a1e8fb746763b5057e0ad91e283b

Readers do not have to visit GitHub at all, and proposed log message shouldn't force them to. Refer to an existing commit in this project like so instead:

    ... as one hour.  d208bfdf (credential: new attribute
    password_expiry_utc, 2023-02-18) added support for this
    attribute in general so that individual credential backend like
    wincred can use it.

>     Help wanted from a Windows user to test. I tried testing on Linux with
>     Wine after cross-compiling [1] but Wine has incomplete support for
>     wincred.h [2]. To test:

I cannot be one to help testing but ...

Show 6 quoted lines

> @@ -292,7 +313,7 @@ int main(int argc, char *argv[])
>  	    "usage: git credential-wincred <get|store|erase>\n";
>  
>  	if (!argv[1])
> -		die(usage);
> +		die("%s", usage);

... this is a nice one. Logically it may belong to a separate topic, but it is small and obvious enough that it is OK to do as a "while at it" clean-up.