Re: [PATCH v4 03/11] commit-reach(repo_in_merge_bases_many): report missing commits

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2024, 16:18 UTC
Message-ID: <xmqqo7by7wno.fsf@gitster.g>
In-Reply-To: <20240301065805.GB2680308@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 16 quoted lines

> On Wed, Feb 28, 2024 at 09:44:09AM +0000, Johannes Schindelin via GitGitGadget wrote:
>
>> @@ -1402,6 +1436,8 @@ static int merge_mode_and_contents(struct merge_options *opt,
>>  							&o->oid,
>>  							&a->oid,
>>  							&b->oid);
>> +			if (result->clean < 0)
>> +				return -1;
>
> Sorry, I accidentally commented on v2 of your series a moment ago,
> rather than the most recent version. But this hunk was untouched between
> the two, so the comment still applies:
>
>   https://lore.kernel.org/git/20240301065647.GA2680308@coredump.intra.peff.net/
>
> -Peff

Thanks for spotting.

The topic now is in 'next' so let's fix it incrementally while I'll hold it there. If all of us thought it has seen enough eyeballs and is good enough for 'next', yet we later find there was something we all missed, that is worth a separate explanation, e.g., "The primary motivation behind the series is still good, but for such and such reasons we missed this case we are fixing."