Re: [PATCH 1/6] CodingGuidelines: describe "export VAR=VAL" rule

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 6, 2024, 05:47 UTC
Message-ID: <xmqqo7anm4a0.fsf@gitster.g>
In-Reply-To: <CAPig+cRjqe-rgYf5UZr9KXmfSw98ZoYjPo5PKhwzRaC-svwshA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 8 quoted lines

>> +   lines.  Note that this was reported in 2013 and the situation might
>> +   have changed since then.  We'd need to re-evaluate this rule,
>> +   together with the rule in t/check-non-portable-shell.pl script.
>
> The bit starting at "Note that..." seems more appropriate for the
> commit message (which is already the case) or a To-Do list. People
> reading this document are likely newcomers looking for concrete
> instructions about how to code for this project,...

Very true. I thought I'd move some to the log message, but it turns out that enough is already described there.

Thanks.