Re: [PATCH] format-patch: ensure that --rfc and -k are mutually exclusive

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2024, 15:43 UTC
Message-ID: <xmqqo7a5mk8f.fsf@gitster.g>
In-Reply-To: <0d584b86-0b48-4e7f-b81c-fdb672dac98b@app.fastmail.com>

"Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:

Show 12 quoted lines

> On Fri, Apr 19, 2024, at 03:05, Dragan Simic wrote:
>> Fix a bug that allows the "--rfc" and "-k" options to be specified together
>> when "git format-patch" is executed, which was introduced in the commit
>> e0d7db7423a9 ("format-patch: --rfc honors what --subject-prefix sets").
>>
>> Add a couple of additional tests to t4014, to cover additional cases of
>> the mutual exclusivity between different "git format-patch" options.
>>
>> Signed-off-by: Dragan Simic <dsimic@manjaro.org>
>
> Looks good to me FWIW. Also very good description of the changes from
> the previous version to this one.

Yup, very easy to follow what changed and how.

Will queue, thanks all.