git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] completion: add docs on how to add subcommand completions

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 24, 2024, 22:22 UTC
Message-ID
<xmqqo79ywgd3.fsf@gitster.g>
In-Reply-To
<20240424210549.256256-2-rhi@pengutronix.de>
Roland Hieber <rhi@pengutronix.de> writes:
> It took me more than a few tries and a good lecture of __git_main to
> understand that the two paragraphs above really only refer to adding
> completion functions for executables that are not called through git's
> subcommand magic. Add a few sentences for that case.

OK. Perhaps the two examples also need some more explanation to save the next person from wasting their time figuring out what they are trying to say? That would be a separate topic, but it would be nice to fix it while our minds are fresh on that issue.

As I already said, modulo confusion around "-my", the patch looks good to me.

Thanks.
Previous: Roland Hieber
Message 6 of 6 in “completion: add 'symbolic-ref'”
  1. 1/2 completion: add 'symbolic-ref'Roland Hieber, Apr 24, 2024
  2. 2/2 completion: add docs on how to add subcommand completionsRoland Hieber, Apr 24, 2024
  3. Roland HieberApr 24, 2024
  4. Junio C HamanoApr 24, 2024
  5. Roland HieberApr 24, 2024
  6. Junio C HamanoApr 24, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.