git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t7300-clean.sh: use test_path_* helper functions

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 8, 2024, 18:13 UTC
Message-ID
<xmqqo73u1n0k.fsf@gitster.g>
In-Reply-To
<CADYq+fYZSGBTnO+dM+MtHj=oUMqDWt+6wu-wEzwfWQJkSomkWA@mail.gmail.com>
Samuel Abraham <abrahamadekunle50@gmail.com> writes:
> ...
>  This was the reason for replacing "test ! -[df]" with
> "test_path_is_missing" where I think is appropriate.

Telling that concisely in the proposed log message will help those who are reviewing the patch and those who are reading "git log -p" later, and that is what I would want to see after a review exchange like this.

Thanks.
Previous: Samuel AbrahamNext: Samuel Abraham
Message 6 of 15 in “t7300-clean.sh: use test_path_* helper functions”
  1. t7300-clean.sh: use test_path_* helper functionsSamuel Adekunle Abraham via GitGitGadget, Oct 7, 2024
  2. Usman AkinyemiOct 7, 2024
  3. Junio C HamanoOct 8, 2024
  4. Samuel AbrahamOct 8, 2024
  5. Samuel AbrahamOct 8, 2024
  6. Junio C HamanoOct 8, 2024
  7. Samuel AbrahamOct 9, 2024
  8. Patrick SteinhardtOct 9, 2024
  9. Samuel AbrahamOct 9, 2024
  10. Junio C HamanoOct 9, 2024
  11. t7300-clean.sh: use test_path_* helper functions for error loggingSamuel Adekunle Abraham via GitGitGadget, Oct 8, 2024
  12. t7300-clean.sh: use test_path_* helper functions for error loggingSamuel Adekunle Abraham via GitGitGadget, Oct 9, 2024
  13. Junio C HamanoOct 9, 2024
  14. Samuel AbrahamOct 9, 2024
  15. t7300-clean.sh: use test_path_* helper functions for error loggingSamuel Adekunle Abraham via GitGitGadget, Oct 9, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.