git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC PATCH] builtin/format-patch: print a warning for skipped merge commits?

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 31, 2025, 05:12 UTC
Message-ID
<xmqqo6nfdyl4.fsf@gitster.g>
In-Reply-To
<20251231034217.2498648-1-asmadeus@codewreck.org>
Dominique Martinet <asmadeus@codewreck.org> writes:
> This RFC patch illustrates how we could easily print a warning, but
> perhaps the warning would only make sense if no other commit has been
> formatted?

Yeah, when nothing is shown but the given range is not empty, it would not be too annoying to give an advice message.

On the other hand, I do not think it is a good idea to say anything extra when the user gave a range "trunk..mytopic" that has repeated back-merges from trunk into mytopic, to format what s/he worked on the mytopic branch. They _expect_ these back-merges to be ignored, and it would be purely an unwanted noise.

Thanks.
Previous: Dominique MartinetNext: Jeff King
Message 2 of 6 in “builtin/format-patch: print a warning for skipped merge commits?”
  1. builtin/format-patch: print a warning for skipped merge commits?Dominique Martinet, Dec 31, 2025
  2. Junio C HamanoDec 31, 2025
  3. Jeff KingJan 2, 2026
  4. Dominique MartinetJan 3, 2026
  5. Junio C HamanoJan 4, 2026
  6. Dominique MartinetFeb 1, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.