git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Make 'trust_executable_bit' repository-scoped

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 9, 2026, 22:03 UTC
Message-ID
<xmqqo6kw3bjp.fsf@gitster.g>
In-Reply-To
<615caf83-71be-43a6-bcb0-3a0c5e14d699@malon.dev>
Tian Yuchen <cat@malon.dev> writes:
Show 22 quoted lines
> Hi drona,
>
> Junio C Hamano <gitster@pobox.com> writes:
>
>  > There were discussions on pros and cons moving global recipients of
>  > configuration values into a dynamically allocated strucrure...
>  > and excellent pieces of advice have been given by Phillip Wood.
>  > If anything, a change like this should ask for input from him.
>
> That makes sense. I think you should CC him whenever you've thoroughly 
> polished the patch or when you encounter unresolved issues.
>
>  > This "v2" applies to a mythical codebase where trust_executable_bit
>  > is somehow a member in the settings structure, which I do not think
>  > we have.
>
> Given Junio's observation, it seems this iteration is targeting an 
> incorrect or non-existent codebase structure.
>
> I'll hold off on further reviews of the specific implementation details
> until the base codebase issue is sorted out and the structural design
> (incorporating Phillip's previous advice) is settled.

I think what the author called v2 was actually [2/N] where the previous version was treated as [1/N] of the same series. The line I noticed was strange in my response is probably correcting what the previous one did, which is not what we want to see. It probably is similar to https://lore.kernel.org/git/xmqqh5qxzzzn.fsf@gitster.g/

We prefer the patch authors to pretend to be a perfect developer who never made any mistakes while writing their series.

This unfortunately is a recurring theme among new developers.

https://lore.kernel.org/git/xmqqk29bsz2o.fsf@gitster.mtv.corp.google.com/ https://lore.kernel.org/git/xmqqd0ds5ysq.fsf@gitster-ct.c.googlers.com/ https://lore.kernel.org/git/xmqqr173faez.fsf@gitster.g/

Previous: Tian YuchenNext: Junio C Hamano
Message 9 of 11 in “Refactor 'trust_executable_bit' to repository-scoped setting”
  1. Refactor 'trust_executable_bit' to repository-scoped settingdrona, Mar 1, 2026
  2. Tian YuchenMar 6, 2026
  3. Make 'trust_executable_bit' repository-scopeddrona, Mar 8, 2026
  4. [PATCH v2] Make 'trust_executable_bit' repository-scopeddrona, Mar 8, 2026
  5. Make 'trust_executable_bit' repository-scopeddrona, Mar 8, 2026
  6. cat@malon.devMar 9, 2026
  7. Dronaraj GyawaliMar 9, 2026
  8. Tian YuchenMar 9, 2026
  9. Junio C HamanoMar 9, 2026
  10. Junio C HamanoMar 9, 2026
  11. Dronaraj GyawaliMar 9, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.