git/list[1] front-page[2] threads[3] people[4] search[5] about
wed 2026-10-07 18:14 UTC

Re: [PATCH v2 0/3] contrib/subtree: reduce recursion during split

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 15, 2026, 17:58 UTC
Message-ID
<xmqqo6jk6r7k.fsf@gitster.g>
In-Reply-To
<xmqqbjgr1g9q.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 27 quoted lines
>>> Depending on the history graph, subtree split can recurse deeply
>>> enough to encounter this limit. Rewrite the rejoin-deepening
>>> algorithm to reduce recursive calls.
>>>
>>> ---
>>> Changes in v2:
>>> - Rebase on master
>>
>> We have seen two iterations of this series without anybody
>> commenting on it.  Is it a sign that the topic, or possibly "git
>> subtree" itself, is of interest to nobody?  Or is it that it is so
>> well done that nobody had any comment on it?
>>
>> I don't use "git subtree" myself, and I do not know of anybody who
>> will scream at me if I break it by merging an unreviewed patch, so I
>> can merge it without worrying too much about fallout personally, but
>> that is a tad irresponsible as the maintainer ;-)
>>
>> So...?  Any volunteers among those who have a higher stake in the
>> program than I do (which admittedly is not a high bar to cross)?
>
> FWIW, I can see that [1/3] is a benign clean-up that should not
> change any semantics.  [2/3] talks about the variable $sub, which is
> used elsewhere, is not protected ...
> ... in "git subtree" to verify), but otherwise the change looks benign
> to me.  I have no idea if what [3/3] does is sensible or not (and
> again, I'd rather want to see somebody with stakes to double check).
So, yet not any volunteers?
Previous: Junio C HamanoNext: Ben Knoble
Message 7 of 22 in “contrib/subtree: reduce function side-effects”
  1. 1/3 contrib/subtree: reduce function side-effectsColin Stagner, Mar 5, 2026
  2. 2/3 contrib/subtree: functionalize split traversalColin Stagner, Mar 5, 2026
  3. 3/3 contrib/subtree: reduce recursion during splitColin Stagner, Mar 5, 2026
  4. 0/3 contrib/subtree: reduce recursion during splitColin Stagner, Mar 5, 2026
  5. Junio C HamanoMar 13, 2026
  6. Junio C HamanoMar 13, 2026
  7. Junio C HamanoApr 15, 2026
  8. Ben KnobleApr 15, 2026
  9. Ian JacksonApr 16, 2026
  10. Junio C HamanoApr 16, 2026
  11. Colin StagnerApr 17, 2026
  12. Ian JacksonApr 19, 2026
  13. Ben KnobleApr 20, 2026
  14. Junio C HamanoApr 20, 2026
  15. Ian JacksonApr 20, 2026
  16. Colin StagnerApr 21, 2026
  17. Johannes SchindelinApr 22, 2026
  18. git-subtree rewriteIan Jackson, Apr 22, 2026
  19. Junio C HamanoJun 1, 2026
  20. Ian JacksonJun 2, 2026
  21. Colin StagnerJun 3, 2026
  22. Ian JacksonJun 3, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.