Re: [PATCH] log: let --follow follow renames in merge commits
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 19, 2026, 06:37 UTC
- Message-ID
- <xmqqo6ib7vlp.fsf@gitster.g>
- In-Reply-To
- <agwAkHzjrJQPVtCS@collabora.com>
Miklos Vajna <vmiklos@collabora.com> writes:
Show 7 quoted lines
> Hi Junio, > > On Tue, May 12, 2026 at 09:21:17AM +0200, Miklos Vajna <vmiklos@collabora.com> wrote: >> I sent this out a week ago at >> <https://lore.kernel.org/git/afmfSa-p-9vuDL3E@collabora.com/T/#u>, I >> didn't get any reply to it -- so I'm somewhat optimistic that the patch >> itself is a good idea, seeing no negative comments.
The patch collecting no comments is just that--nobody so far is interested enough to drop other things they were doing to give supporting code reviews---and "no news" does not mean a good news.
Show 8 quoted lines
>> So this is a resend, this time to you, CC'ing the list, rather than the >> other way around. >> >> Could you please review this? > > I'm a bit confused regarding what can be a next step here. I > understanding you were away for 3 weeks, so there is a lot to process. > :-) Should I just wait more or should I resend this?
Rather, ask other reviewers; when I do not comment on a patch, I often am not interested, or too busy and the change does not look interesting enough to me to make me drop what I am doing.