Re: [PATCH] lint-gitlink: don't use empty lower bound in .{0,8}
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Sep 8, 2026, 03:37 UTC
- Message-ID
- <xmqqo6e8za5e.fsf@gitster.g>
- In-Reply-To
- <20260907184858.13475-1-taahol@utu.fi>
Tuomas Ahola <taahol@utu.fi> writes:
Show 7 quoted lines
> The regex quantifier {,n} was added in Perl 5.34.0 as a shorthand
> for {0,n}. That makes it too new an introduction for Git which
> targets Perl 5.26.0.
>
> Even though Documentation/lint-gitlink.perl is a development helper
> script, let's stick to the general Perl version requirement for
> consistency, and use an explicit zero in .{0,8}.I am curious how you found this.
I somehow find it unlikely that you were sticking to Perl 5.26, ran "make -C Documentation lint-docs" and saw your tad old Perl complain for syntax too new.
Perl 5.26 is from May 2017 while Perl 5.34 is from May 2021 if https://cpan.org/src/ is to be believed.
Will queue. Thanks.
Show 20 quoted lines
> Signed-off-by: Tuomas Ahola <taahol@utu.fi>
> ---
> Documentation/lint-gitlink.perl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/lint-gitlink.perl b/Documentation/lint-gitlink.perl
> index a92e887b4c..6a87633dd4 100755
> --- a/Documentation/lint-gitlink.perl
> +++ b/Documentation/lint-gitlink.perl
> @@ -42,7 +42,7 @@ sub report {
> while (<>) {
> my $line = $_;
> next if $line =~ /^\s*(ifn?def|endif)::/;
> - while ($line =~ m/(.{,8})((git[-a-z]+|scalar)\[(\d)*\])/g) {
> + while ($line =~ m/(.{0,8})((git[-a-z]+|scalar)\[(\d)*\])/g) {
> my $pos = pos $line;
> my ($macro, $target, $page, $section) = ($1, $2, $3, $4);
> if ( $macro ne "linkgit:" ) {
>
> base-commit: e9019fcafe0040228b8631c30f97ae1adb61bcdc