git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Make the global packed_git variable static to sha1_file.c.

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 12, 2014, 20:28 UTC
Message-ID
<xmqqmwhwm5yj.fsf@gitster.dls.corp.google.com>
In-Reply-To
<52fbc2d6.7kJdh2GOdWTzNcPK%szager@chromium.org>
I'll locally fix up these style issues before commenting on the patch.
Thanks.
ERROR: space required after that ',' (ctx:VxV)
#78: FILE: builtin/count-objects.c:111:
+	struct pack_data pd = {0,0,0};
 	                        ^
ERROR: space required after that ',' (ctx:VxV)
#78: FILE: builtin/count-objects.c:111:
+	struct pack_data pd = {0,0,0};
 	                          ^
ERROR: space required after that ',' (ctx:VxV)
#171: FILE: builtin/fsck.c:683:
+		struct verify_packs_data vpd = {0,0,0};
 		                                 ^
ERROR: space required after that ',' (ctx:VxV)
#171: FILE: builtin/fsck.c:683:
+		struct verify_packs_data vpd = {0,0,0};
 		                                   ^
ERROR: space required after that ',' (ctx:VxV)
#541: FILE: builtin/pack-redundant.c:591:
+	struct add_pack_data apd = {filename,0,NULL};
 	                                    ^
ERROR: space required after that ',' (ctx:VxV)
#541: FILE: builtin/pack-redundant.c:591:
+	struct add_pack_data apd = {filename,0,NULL};
 	                                      ^
ERROR: space required after that ',' (ctx:VxV)
#565: FILE: builtin/pack-redundant.c:604:
+	struct add_pack_data apd = {NULL,0,NULL};
 	                                ^
ERROR: space required after that ',' (ctx:VxV)
#565: FILE: builtin/pack-redundant.c:604:
+	struct add_pack_data apd = {NULL,0,NULL};
 	                                  ^
ERROR: space prohibited after that '-' (ctx:WxW)
#726: FILE: pack-revindex.c:47:
+	num = - 1 - num;
 	      ^
ERROR: space required after that ',' (ctx:VxV)
#901: FILE: sha1_name.c:195:
+	struct disambiguate_data d = {len,bin_pfx,ds};
 	                                 ^
ERROR: space required after that ',' (ctx:VxV)
#901: FILE: sha1_name.c:195:
+	struct disambiguate_data d = {len,bin_pfx,ds};
 	                                         ^
total: 11 errors, 0 warnings, 781 lines checked
Previous: szager@chromium.orgNext: Junio C Hamano
Message 2 of 4 in “Make the global packed_git variable static to sha1_file.c.”
  1. Make the global packed_git variable static to sha1_file.c.szager@chromium.org, Feb 12, 2014
  2. Junio C HamanoFeb 12, 2014
  3. Junio C HamanoFeb 12, 2014
  4. Stefan ZagerFeb 13, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.