Re: with reuse-delta patches, fetching with bitmaps segfaults due to possibly incomplete bitmap traverse

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 24, 2014, 20:30 UTC
Message-ID: <xmqqmwgfpce5.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140322125626.GA22890@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 12 quoted lines

> On Fri, Mar 21, 2014 at 07:58:55PM -0700, Siddharth Agarwal wrote:
>
>> At Facebook we've found that fetch speed is a bottleneck for our Git repos,
>> so we've been looking to deploy bitmaps to speed up fetches. We've been
>> trying out git-next with the top two patches from
>> https://github.com/peff/git/commits/jk/bitmap-reuse-delta, but the following
>> is reproducible with tip of that branch, currently 81cdec2.
>
> Is it also reproducible just with the tip of "next"? Note that the
> patches in jk/bitmap-reuse-delta have not been widely deployed (in
> particular, we are not yet using them at GitHub, and we track segfaults
> on our servers closely and have not seen any related to this).

Nice to hear. I was worried for a short while if I merged what was not cooked well, before I realized that Siddharth is on a codebase that is more bleeding edge than I use myself ;-)