Re: [PATCH 2/2] rev-parse: honor --quiet when asking for reflog dates that do not exist

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 18, 2014, 16:12 UTC
Message-ID: <xmqqmw9wq54z.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1410928530-21595-2-git-send-email-davvid@gmail.com>

David Aguilar <davvid@gmail.com> writes:

Show 11 quoted lines

> @@ -514,8 +514,11 @@ static int get_sha1_basic(const char *str, int len, unsigned char *sha1,
>  
>  	if (warn_ambiguous_refs &&
>  	    (refs_found > 1 ||
> -	     !get_short_sha1(str, len, tmp_sha1, GET_SHA1_QUIETLY)))
> -		warning(warn_msg, len, str);
> +	     !get_short_sha1(str, len, tmp_sha1, GET_SHA1_QUIETLY))) {
> +		if (!(flags & GET_SHA1_QUIETLY)) {
> +			warning(warn_msg, len, str);
> +		}
> +	}

Hmph, wouldn't it be simpler to read and understand if it were done this way instead?

-	if (warn_ambiguous_refs &&
+	if (warn_ambiguous_refs && !(flags & GET_SHA1_QUIETLY) &&
 	    (refs_found > 1 || !get_short_sha1(...)))
		waqrning(...);