Re: [PATCH] versionsort: support reorder prerelease suffixes

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 5, 2015, 01:28 UTC
Message-ID: <xmqqmw3s5j1y.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqvbinhw7l.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 21 quoted lines

>> +versionsort.prereleaseSuffix::
>> +	When version sort is used in linkgit:git-tag[1], prerelease
>> +	tags (e.g. "1.0-rc1") may appear after the main release
>> +	"1.0". By specifying the suffix "-rc" in this variable,
>> +	"1.0-rc1" will appear before "1.0". One variable assignment
>> +	per suffix.
>
> I think the last half-sentence want to mean that
>
> 	[versionsort]
>                 prereleaseSuffix = -pre
>         	prereleaseSuffix = -rc
>
> is the supported way to write, and not
>
> 	[versionsort]
>         	prereleaseSuffix = -pre -rc
>
> but it probably is unclear unless the reader already knows what it
> is trying to say.  The reader also needs to learn somewhere how the
> order of the entries affects the result.

This is already in 'next', so could you fix that half-sentence in the documentation via an incremental update?

Thanks.