Re: [PATCH v6 3/3] diff: add SUBMODULE_DIFF format to display submodule diff
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 16, 2016, 21:31 UTC
- Message-ID
- <xmqqmvkcbdui.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CA+P7+xrnUAN8M4UX0hZN213yUKndb_4d+AjohWV45KvCdJm9PQ@mail.gmail.com>
Jacob Keller <jacob.keller@gmail.com> writes:
> Thoughts on that? Or should we just limit ourselves to only some > options get propagated to the submodule?
I think you have to be selective either way. You do not want pathspecs used to limit the top-level paths propagated down when you run a diff or a log in the submodule, for example, and that does not change even if you start using the code in diff-lib.c (after adding the submodule odb as an alternate).