Re: [PATCH] push: change submodule default to check

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 17, 2016, 21:05 UTC
Message-ID: <xmqqmvkb85sw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160817204848.8983-1-sbeller@google.com>

Stefan Beller <sbeller@google.com> writes:

> If working with submodules, there are more reports of missing submodules
> rather than the desire to push the superproject without the submodules
> to be pushed out.

I do not know how you are counting the "more reports" part of that assertion, but it is very likely that it is biased by the current default. If you flip the default, you would see more reports that say "I know I wasn't ready to push the submodule part out; don't bug me".

IOW, those who want to have something different always sound louder, because people who are satisified tend to stay silent.

> Flipping the default to check for submodules is safer
> than the current default of ignoring submodules while pushing.

That part of the assertion, on the other hand, is justifiable.

Show 5 quoted lines

> Signed-off-by: Stefan Beller <sbeller@google.com>
> ---
>  
>  Probably too late for the 2.10 release as I'd propose to keep it in master for
>  quite a while before actually doing a release with this.

I think you meant 'next' not 'master'. We have a few "let's keep it in 'next' to see if people scream" topics there already--the more the merrier? ;-)