Re: [PATCH 3/3] submodule--helper: add intern-git-dir function
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 22, 2016, 07:07 UTC
- Message-ID
- <xmqqmvgsf0wo.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAGZ79kb_4wWs_90AfsT932iPWbCXf6yRq875JUxoRZjUcsBW5A@mail.gmail.com>
Stefan Beller <sbeller@google.com> writes:
Show 9 quoted lines
> So I guess we should test a bit more extensively, maybe > > git status >expect > git submodule embedgitdirs > git status >actual > test_cmp expect actual > # further testing via > test -f .. > test -d ..
Something along that line. "status should succeed" does not tell the readers what kind of breakage the test is expecting to protect us from. If we are expecting a breakage in embed-git-dirs would somehow corrupt an existing submodule, which would lead to "status" that is run in the superproject report the submodule differently, then comparing output before and after the operation may be a reasonable test. Going there to the submodule working tree and checking the health of the repository (of the submodule) may be another sensible test.
Show 10 quoted lines
>> In the >> extreme, if the failed "git submodule" command did >> >> rm -fr .git ?* && git init >> >> wouldn't "git status" still succeed? > > In that particular case you'd get > $ git status > fatal: Not a git repository (or any parent up to mount point ....)
Even with "&& git init"? Or you forgot that part?