Re: [PATCH v2 2/2] Documentation: Link descriptions of -z to core.quotePath

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2017, 20:51 UTC
Message-ID: <xmqqmvd6jayn.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1487968676-6126-3-git-send-email-asheiduk@gmail.com>

Andreas Heiduk <asheiduk@gmail.com> writes:

Show 15 quoted lines

> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt
> index e6215c3..7c28e73 100644
> --- a/Documentation/diff-options.txt
> +++ b/Documentation/diff-options.txt
> @@ -192,10 +192,9 @@ ifndef::git-log[]
>  	given, do not munge pathnames and use NULs as output field terminators.
>  endif::git-log[]
>  +
> -Without this option, each pathname output will have TAB, LF, double quotes,
> -and backslash characters replaced with `\t`, `\n`, `\"`, and `\\`,
> -respectively, and the pathname will be enclosed in double quotes if
> -any of those replacements occurred.
> +Without this option, pathnames with "unusual" characters are munged as
> +explained for the configuration variable `core.quotePath` (see
> +linkgit:git-config[1]).

Seeing that many other instances call this "quoted", we may want to be consistent. I can see "munge" in the pre-context, but that one can stay as is. Under -z, no modification/munging happens. With -z, a specific kind of modification (called "quote" described in the documentation for core.quotepath variable) happens. The same comment applies to the change to Documentation/git-apply.txt

Otherwise the patch looks good.

Thanks.