Re: t5545: reduced test coverage

From: Junio C Hamano <gitster@pobox.com>
Date: May 17, 2017, 03:56 UTC
Message-ID: <xmqqmvacxhk0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqqbmqsyzn7.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 5 quoted lines

> It appears to me that only a few tests in the entire script wants to
> work with HTTP server, so perhaps moving them to the end, together
> with the inclusion of lib-httpd and start_httpd that 438fc684 ("push
> options: pass push options to the transport helper", 2017-02-08)
> introduced, may be sufficient?

Probably not, as lib-httpd, when it gives up, does the "skip_all=message; test_done" thing, which makes test_done to trigger this:

	# Maybe print SKIP message
	if test -n "$skip_all" && test $test_count -gt 0
	then
		error "Can't use skip_all after running some tests"
	fi

So a bit more work is needed, than just moving things around, I am afraid...