Re: [PATCH v2] commit: run git gc --auto just before the pre-commit hook

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2018, 23:39 UTC
Message-ID: <xmqqmuzsit0c.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180228230425.14952-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 12 quoted lines

>> Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:
>>
>>> Change the behavior of git-commit back to what it was back in
>>> d4bb43ee27 ("Invoke "git gc --auto" from commit, merge, am and
>>> rebase.", 2007-09-05) when it was git-commit.sh.
>>
>> ... which was to run it just before post-commit.  Do I retitle this
>> patch before queuing?
>
> Do'h. Of course I screw up something simple like that, sorry. This v2
> fixes it, and I also rephrased the commit message a bit (more commas &
> full-stops).

I guess I still need to retitle it ;-) But that can happen tomorrow (I have the previous one with local fixes that pretty much matches v2 modulo the body of the log message on 'pu', ready to be pushed out).

> I wonder if it would also be a good idea to run git gc --auto on "git
> push". It itself won't create any objects, but it would be a nice
> proxy in many cases for picking up anything else we missed due to
> various object writing commands that won't run --auto.

Before "push" starts producing a pack might be a good optimization, as reading from a packed repository is often more performant than a repository full of loose objects.