Re: [PATCH] revisions.txt: expand tabs to spaces in diagram

From: Junio C Hamano <gitster@pobox.com>
Date: May 4, 2018, 02:32 UTC
Message-ID: <xmqqmuxgtal8.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180504015202.GP13217@genre.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 17 quoted lines

> ...  We can help both AsciiDoc and Asciidoctor do the right thing
> here (and keep our 8-space tabs) by enclosing the diagram in a block
> like so:
>
> [literal]
> --
>    Args   Expanded arguments    Selected commits
>    D                            G H D
>    D F                          G H I J D F
>    ...
> 	  = B ^D ^E ^F          B
>    F^! D  = F ^I ^J D           G H D F
> --
>
> and using the tabsize=8 attribute when invoking Asciidoctor.  I can send
> a patch tomorrow which does this, which I think may be a bit nicer than
> having to give up tabs.

Yeah, trying to forbid indent-with-tab has been shown to be unworkable so even if we tried to give up tabs, it is likely we would break it by mistake. Allowing indent-with-tab and ask the tool to do the right thing is obviously the right direction.

Thanks.