Re: [ANNOUNCE] Git v2.18.0-rc1

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 11, 2018, 16:14 UTC
Message-ID: <xmqqmuw147xq.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <781A6400-477F-4A7B-8C17-65BFD280B331@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 15 quoted lines

>> On 04 Jun 2018, at 06:53, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> A release candidate Git v2.18.0-rc1 is now available for testing
>> at the usual places.  It is comprised of 842 non-merge commits
>> since v2.17.0, contributed by 65 people, 20 of which are new faces.
>> 
>> ...
>> 
>> * The new "checkout-encoding" attribute can ask Git to convert the
>>   contents to the specified encoding when checking out to the working
>>   tree (and the other way around when checking in).
>
> Did you call the feature "checkout-encoding" here intentionally?
> The attribute is called "working-tree-encoding" in the final and
> merged round. Shouldn't we call it that way here too?

No.  Yes, absolutely.  Thanks.

 Documentation/RelNotes/2.18.0.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/RelNotes/2.18.0.txt b/Documentation/RelNotes/2.18.0.txt
index 8d0ee5c426..ecd9f8849e 100644
--- a/Documentation/RelNotes/2.18.0.txt
+++ b/Documentation/RelNotes/2.18.0.txt
@@ -50,7 +50,7 @@ UI, Workflows & Features
    have been replaced with a stub that errors out and tells the user
    there are replacements.
 
- * The new "checkout-encoding" attribute can ask Git to convert the
+ * The new "working-tree-encoding" attribute can ask Git to convert the
    contents to the specified encoding when checking out to the working
    tree (and the other way around when checking in).