git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/6] Add merge recursive testcases with undetected conflicts

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 11, 2018, 15:40 UTC
Message-ID
<xmqqmuux4w83.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<CABPp-BGH+6XkJwqhUOydT0CQBRTr=Hf79SU5PGZ2NrvV5uNjCw@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 33 quoted lines
> On Mon, Jul 9, 2018 at 1:22 PM, Elijah Newren <newren@gmail.com> wrote:
>> On Mon, Jul 9, 2018 at 10:53 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Elijah Newren <newren@gmail.com> writes:
>>>
>>>> When a merge succeeds, we expect the resulting contents to depend only
>>>> upon the trees and blobs of the branches involved and of their merge
>>>> base(s).  Unfortunately, there are currently about half a dozen cases
>>>> where the contents of a "successful" merge depend on the relative
>>>> commit timestamps of the merge bases.  Document these with testcases.
>>>>
>>>> (This series came out of looking at modifying how file collision
>>>> conflict types are handled, as discussed at [1].  I discovered these
>>>> issues while working on that topic.)
>>>
>>> I have a topic branch for this series but not merged to 'pu' as
>>> test-lint gives these:
>>>
> ...
>>
>> ... here's a fixup to the topic; as you pointed out, the exact contents
>> of the script being written were actually irrelevant; it was just an
>> input to a merge.
>>
>> -- 8< --
>> Subject: [PATCH] fixup! t6036: add a failed conflict detection case: regular
>>  files, different modes
>>
>
> Does a 'fixup!' commit require a Signed-off-by?  Just realized that
> this one didn't have it, though I don't know if it's necessary.  If it
> is:
>
> Signed-off-by: Elijah Newren <newren@gmail.com>

Thanks. I queued it separately before running out of time Monday, but will actually squash it in to the main patch.

Previous: Elijah Newren
Message 14 of 14 in “Add merge recursive testcases with undetected conflicts”
  1. 0/6 Add merge recursive testcases with undetected conflictsElijah Newren, Jul 1, 2018
  2. 1/6 t6036: add a failed conflict detection case with symlink modify/modifyElijah Newren, Jul 1, 2018
  3. 2/6 t6036: add a failed conflict detection case with symlink add/addElijah Newren, Jul 1, 2018
  4. 4/6 t6036: add a failed conflict detection case with submodule add/addElijah Newren, Jul 1, 2018
  5. 3/6 t6036: add a failed conflict detection case with submodule modify/modifyElijah Newren, Jul 1, 2018
  6. 6/6 t6036: add a failed conflict detection case: regular files, different modesElijah Newren, Jul 1, 2018
  7. 5/6 t6036: add a failed conflict detection case with conflicting typesElijah Newren, Jul 1, 2018
  8. Junio C HamanoJul 9, 2018
  9. Elijah NewrenJul 9, 2018
  10. Jeff KingJul 10, 2018
  11. Elijah NewrenJul 10, 2018
  12. Jeff KingJul 10, 2018
  13. Elijah NewrenJul 11, 2018
  14. Junio C HamanoJul 11, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.