Re: [PATCH 1/1] t7406: avoid failures solely due to timing issues
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 23, 2018, 19:14 UTC
- Message-ID
- <xmqqmuuh69xx.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <78f7a5e4baae162d1dff18701a25903b304adf9e.1532353179.git.gitgitgadget@gmail.com>
"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 13 quoted lines
> To prevent such false positives from unnecessarily costing time when > investigating test failures, let's take the exact order of the lines out > of the equation by sorting them before comparing them. > ... > cat <<EOF >expect2 > +Cloning into '$pwd/recursivesuper/super/merging'... > +Cloning into '$pwd/recursivesuper/super/none'... > +Cloning into '$pwd/recursivesuper/super/rebasing'... > +Cloning into '$pwd/recursivesuper/super/submodule'... > Submodule 'merging' ($pwd/merging) registered for path '../super/merging' > Submodule 'none' ($pwd/none) registered for path '../super/none' > Submodule 'rebasing' ($pwd/rebasing) registered for path '../super/rebasing' > Submodule 'submodule' ($pwd/submodule) registered for path '../super/submodule'
Thanks. It obviously goes in the right direction to loosen the ordering requirement that fundamentally cannot be met, as the log message cleanly analizes.
Do we know that the write(2)s that show these lines are atomic, or are we merely lucky that we don't see them intermixed in the middle of lines (sbeller cc'ed). I _think_ they are but just wanted to double check.