Re: [PATCH v5 1/8] technical doc: add a design doc for the evolve command

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 15, 2019, 23:36 UTC
Message-ID: <xmqqmumw4ob4.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAPL8ZiseLQgemzr-U2yFM815Ty+Di_cGznZ_hNAcf3sMy5mXEg@mail.gmail.com>

Stefan Xenos <sxenos@google.com> writes:

>> saw a few comments that say "needs further work".
>
> Could you clarify where you saw those comments? Were they something I
> wrote ...

Yeah, e.g.

       /* TODO: This causes a crash. It sets one of the atom_value handlers to
        * something invalid, which causes a crash later when we all
        * show_ref_array_item. Figure out why this happens and put back the sorting.
        *ref_array_sort(sorting, &array); */

was what caught my attention in the previous and this version. As I said, it is OK if the code is not completely finished. It's an iterative process.

By the way, our multi-line comments have opening /* and closing */ on their own lines.

Thanks.