Re: [PATCH 1/3] builtin/log: downcase the beginning of error messages

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 22, 2019, 20:40 UTC
Message-ID: <xmqqmumnpneh.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAPig+cRhk-0LBCmUQ4LszJrnmnXCDz7HxWqDnKX53woBYhr-KQ@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 6 quoted lines

>> -                       die(_("Failed to get upstream, if you want to record base commit automatically,\n"
>> +                       die(_("failed to get upstream, if you want to record base commit automatically,\n"
>>                               "please use git branch --set-upstream-to to track a remote branch.\n"
>>                               "Or you could specify base commit by --base=<base-commit-id> manually."));
>
> The capitalized "Or you..." is odd after s/Failed/failed/.

It briefly bothered me, too, but after realizing that this is not the whole sentence, it no longer looks so bad to me. The thing is that "Failed" (or "failed") is *not* what starts the message. This one is die(), so what you'd actually see is

	fatal: failed to get upstream, ... to track a remote branch.
	Or you could ...

with "fatal:" prefix.