Re: [PATCH] fetch-pack: write fetched refs to .promisor

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 27, 2019, 20:27 UTC
Message-ID: <xmqqmufu2w25.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190826214737.164132-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

> As written in the NEEDSWORK comment, repack does not preserve the
> contents of .promisor files, but I thought I'd send this out anyway as
> this change is already useful for users who don't run repack much.

What do you exactly mean by "much" here? The comment sounds like it is saying "running this code once and you'd make the commits and objects that were depending on the existing promisor invalid", in which case it would be more like "it is already useful for users until they run their first repack that destroyes their repository", but certainly that is not what we want to do, so...

Show 11 quoted lines

> +test_expect_success 'verify that .promisor file contains refs fetched' '
> +	ls pc1/.git/objects/pack/pack-*.promisor >promisorlist &&
> +	test_line_count = 1 promisorlist &&
> +	git -C srv.bare rev-list HEAD >headhash &&
> +	grep "$(cat headhash) HEAD" $(cat promisorlist) &&
> +	grep "$(cat headhash) refs/heads/master" $(cat promisorlist)
> +'
> +
>  # checkout master to force dynamic object fetch of blobs at HEAD.
>  test_expect_success 'verify checkout with dynamic object fetch' '
>  	git -C pc1 rev-list --quiet --objects --missing=print HEAD >observed &&