git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t1091: don't grep for `strerror()` string

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 9, 2020, 15:04 UTC
Message-ID
<xmqqmu8p1seh.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<20200308084627.26677-1-martin.agren@gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
Show 7 quoted lines
> We grep for "File exists" in stderr of the failing `git sparse-checkout`
> to make sure that it failed for the right reason. We expect the string
> to show up there since we call `strerror(errno)` in
> `unable_to_lock_message()` in lockfile.c.
>
> On the NonStop platform, this fails because the error string is "File
> already exists", which doesn't match our grepping.

Thanks for a quick fix. I agree that looking for our own string makes a lot more sense here.

Previous: Derrick Stolee
Message 4 of 4 in “[Test] t1901 - sparse checkout file when lock is taken fails (subtest 19)”
  1. Randall S. BeckerMar 5, 2020
  2. t1091: don't grep for `strerror()` stringMartin Ågren, Mar 8, 2020
  3. Derrick StoleeMar 9, 2020
  4. Junio C HamanoMar 9, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.