Re: [PATCH v8 0/6] Finish converting git bisect to C part 2 subset 1

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 23, 2020, 16:14 UTC
Message-ID: <xmqqmu1gjwqm.fsf@gitster.c.googlers.com>
In-Reply-To: <20200923072740.20772-1-mirucam@gmail.com>

Miriam Rubio <mirucam@gmail.com> writes:

Show 10 quoted lines

> These patches correspond to a second part of patch series 
> of Outreachy project "Finish converting `git bisect` from shell to C" 
> started by Pranit Bauva and Tanushree Tumane
> (https://public-inbox.org/git/pull.117.git.gitgitgadget@gmail.com) and
> continued by me.
>
> This patch series version is composed by the first six patches of the
> previous version due to a bug discovered during the test stage, that 
> affects the rest of the patches and that needs to be fixed before 
> sending them.

Thanks for being careful.

> * Rebased on 385c171a01, (Fifteenth batch, 2020-09-18) to update command
> help messages.

Personally I find this rebase unwarranted. What ef4d9f8a (bisect: swap command-line options in documentation, 2020-08-28) on the 'master' did does not overlap with this series in any meaningful way. Since it is also trivial to adjust these patches back on e9b77c84 (Tenth batch, 2020-08-24) on which the previous round was based, I won't complain ;-)

Show 5 quoted lines

> [4/6] bisect--helper: reimplement `bisect_autostart` shell function in C
>
> * Amend commit message.
> * Change to `return -1` when we cannot autostart.
> * Add `|| exit` to bisect-autostart call in shell script.

Sounds good.

Show 5 quoted lines

> [6/6] bisect--helper: reimplement `bisect_next` and `bisect_auto_next` shell
>  functions in C
>  
> * Amend commit message.
> * Amend new modes order in cmdmode enum.

Meaning that the two new ones can just be at the end and there wasn't a reason for them to come before autostart? OK.

> * Add `|| exit` to bisect-auto-next call in shell script.

OK.

Thanks.