Re: [PATCH 2/2] revision: implement --show-linear-break for --graph
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 18, 2021, 21:01 UTC
- Message-ID
- <xmqqmtx6j6wt.fsf@gitster.c.googlers.com>
- In-Reply-To
- <04c81462-3181-37d7-0109-4292040b84e9@pdinc.us>
Kyle Marek <kmarek@pdinc.us> writes:
> Me too, but I think a user-defined mark needs to be a string to > support Unicode characters.
Ahh, I didn't even consider making it user-defined.
As it seems a lot safer to make this an optional feature, it does sort-of make sense to let the letters used for root & left-root be customizable, and it does make sense to take a multi-byte character, but I am not sure what implications it has if we allowed any string without ensuring that it occupies one display column.