Re: [PATCH] refs: cleanup directories when deleting packed ref

From: Junio C Hamano <gitster@pobox.com>
Date: May 8, 2021, 06:24 UTC
Message-ID: <xmqqmtt5vj2x.fsf@gitster.g>
In-Reply-To: <1bb65e54-a18d-852d-bb01-130cc57cce1b@gmail.com>

Bagas Sanjaya <bagasdotme@gmail.com> writes:

> I ask to you: why did you send v2 patch as reply to v1?

Because it is a natural progression of the ongoing discussion, I would presume?

> Supposed that I interested to apply only this v2, instead of v1.
> With this situation, I downloaded mbox for v1, which contains v2
> patch as reply to v1. And git-am would instead apply v1 instead.

If you are interested in v2, fetch individual pieces of e-mail for v2 and not v1 (in this case, a single message that contains v2 only). If you feed v1 to "am", of course it would happily apply it. Or if you grab the whole discussion in a mbox, of couse you'd need to pick the message you would want to use (e.g. "mailx -f mbox" and choose individual messages and then tell it to "s"ave).

> So why not send this v2 as separate message-id?

I sense you are somehow upset or frustrated, but I do not see a need to behave so rudely to your fellow community member(s).

By the way, kostantin, "b4 am" seems to mishandle this thread. As I understand it, it is supposed to grab the latest and greatest iteration given any message in the discussion thread, right? In this thread, we discuss a single-patch "series" but with two iterations. The original submission is followed by some discussion messages, that is followed by a v2 patch, and then a few more non-patch messaages.

Between these two invocations

$ b4 am YJVQpaDwkQH/aCee@mini.wfchandler.org $ b4 am YJYa+7yUyt2YD16r@mini.wfchandler.org

where the first one is the the original, and the second one is the improved v2 patch, both requests end up fetching the original one.

One thing curious about the behaviour (see the transcript at the end) is that it gives this "NOTE" about "trailers", which hints me that this vintage of "b4" may not understand the in-body header like "git am" and "git mailinfo" do? The v2 patch begins with a Subject: in-body header to retitle the patch.

FWIW, I am using prepackaged /usr/bin/b4 at a work machine, which identifies itself as

$ b4 --version 0.6.2

Thanks.

---------------------- >8 ----------------------

$ b4 am YJVQpaDwkQH/aCee@mini.wfchandler.org
Looking up https://lore.kernel.org/r/YJVQpaDwkQH%2FaCee%40mini.wfchandler.org
Grabbing thread from lore.kernel.org/git
Analyzing 7 messages in the thread
---
Writing ./20210507_wfc_refs_cleanup_directories_when_deleting_packed_ref.mbx
  ✓ [PATCH] refs: cleanup directories when deleting packed ref
  ---
  ✓ Attestation-by: DKIM/wfchandler.org (From: wfc@wfchandler.org)
---
Total patches: 1
---
NOTE: some trailers ignored due to from/email mismatches:
    ! Trailer: Subject: [PATCH v2] refs: cleanup directories when deleting packed ref
     Msg From: Will Chandler <wfc@wfchandler.org>
NOTE: Rerun with -S to apply them anyway
---
 Link: https://lore.kernel.org/r/YJVQpaDwkQH/aCee@mini.wfchandler.org
 Base: not found (applies clean to current tree)
       git am ./20210507_wfc_refs_cleanup_directories_when_deleting_packed_ref.mbx