Re: [PATCH v2] builtin/fetch: skip unnecessary tasks when using --negotiate-only

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 20, 2021, 22:12 UTC
Message-ID: <xmqqmtkvsz6y.fsf@gitster.g>
In-Reply-To: <kl6lo85byp3b.fsf@chooglen-macbookpro.roam.corp.google.com>

Glen Choo <chooglen@google.com> writes:

Show 5 quoted lines

> But maybe I am misunderstanding how Git treats CLI options in general?
> We don't ever really hide CLI options, even if they are only
> internal. There is PARSE_OPT_HIDDEN, but those still show up in usage
> and documentation [1]. So we actually do want users to know about these
> implementation details?

At least they should be told not to use from the command line when they have no business triggering whatever feature these options trigger.

> Presumably, the thought process goes something like this: if we add an
> option, a user *could* find a use for it (or it might accidentally
> conflict with a user's flags), even if we never intended it for end user
> consumption. Thus we need to treat all CLI options with care.

Rather, they can keep both halves ;-)