Re: [PATCH 0/2] [2.38 regression] config: respect includes in protected config
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 12, 2022, 20:54 UTC
- Message-ID
- <xmqqmta0kbkh.fsf@gitster.g>
- In-Reply-To
- <pull.1360.git.git.1665603814.gitgitgadget@gmail.com>
"Glen Choo via GitGitGadget" <gitgitgadget@gmail.com> writes:
> Here's a fix for the regression reported in [1]. I'm quite confident that > the test suite is extensive enough to catch any unintended behavioral > changes, but I'd appreciate a second opinion.
This hooks onto safe.directory that dates back to 2.30.4 or so, but the topic gc/bare-repo-discovery appears only in 2.38 so we do not have to backport anything beyond the current maintenance track. Whew ;-)
Show 21 quoted lines
> Cc: Derrick Stolee derrickstolee@github.com, Taylor Blau me@ttaylorr.com, > Johannes Schindelin Johannes.Schindelin@gmx.de, Junio C Hamano > gitster@pobox.com > > [1] > https://lore.kernel.org/git/CAPWNY8W_Tr-WoD-GXBddD5Y8w5Y4w+gDNYQdOAJ1uBwVHuRrsQ@mail.gmail.com > > Glen Choo (2): > t0033, t0035: test for included config > config: respect includes in protected config > > config.c | 30 ++++++++---------------------- > t/t0033-safe-directory.sh | 9 +++++++++ > t/t0035-safe-bare-repository.sh | 9 +++++++++ > 3 files changed, 26 insertions(+), 22 deletions(-) > > > base-commit: 3dcec76d9df911ed8321007b1d197c1a206dc164 > Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1360%2Fchooglen%2Fprotected-config%2Frespect-includes-v1 > Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1360/chooglen/protected-config/respect-includes-v1 > Pull-Request: https://github.com/git/git/pull/1360