Re: [PATCH] tree-walk: disallow overflowing modes

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 24, 2023, 20:44 UTC
Message-ID: <xmqqmt67fysf.fsf@gitster.g>
In-Reply-To: <b4b48877-5b80-e96f-d09f-2fe275f42950@web.de>

René Scharfe <l.s.r@web.de> writes:

> ...  It's basically harmless.  Perhaps
> we just need a comment stating that, to contain the urge to "fix" this.

Yeah, especially since fsck finds and warns about bad mode with FSCK_MSG_BAD_FILEMODE and also FSCK_MSG_ZERO_PADDED_FILEMODE in a separate codepath, adding another piece of code that checks a slightly different condition does not sound like a good idea.

Thanks.