git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] Fix mem leak in branch.c due to not-free newly added virtual_name variable

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 22, 2023, 16:52 UTC
Message-ID
<xmqqmt44enj3.fsf@gitster.g>
In-Reply-To
<27f27f3afd76fc974350c0c94e20307879eead84.1679478126.git.gitgitgadget@gmail.com>
"ctmbl via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 6 quoted lines
> From: ctmbl <mabileau.clement@gmail.com>
>
> Previous commit introduced virtual_name variable which is the name of
> the branch in case it has been a remote ref (used to check whether the
> user simply forgot `--remote` flag) but didn't free it.
> Call FREE_AND_NULL(virtual_name) to solve it.

Do not introduce a bug in 1/2 and fix it in 2/2, unless it is absolutely necessary.

Squash this one into the previous commit, before sending your patches out to the list. The public do not have to learn your earlier mistakes, and before sending your patches out is the perfect chance for you to pretend to be a person that is more perfect than you are ;-).

Thanks.
Previous: ctmbl via GitGitGadgetNext: Clement Mabileau
Message 3 of 13 in “branch: improve error log on branch not found by checking remotes refs”
  1. 0/2 branch: improve error log on branch not found by checking remotes refsClementMabileau via GitGitGadget, Mar 22, 2023
  2. 2/2 Fix mem leak in branch.c due to not-free newly added virtual_name variablectmbl via GitGitGadget, Mar 22, 2023
  3. Junio C HamanoMar 22, 2023
  4. Clement MabileauMar 22, 2023
  5. Junio C HamanoMar 22, 2023
  6. 1/2 branch: improve error log on branch not found by checking remotes refsctmbl via GitGitGadget, Mar 22, 2023
  7. branch: improve error log on branch not found by checking remotes refsClementMabileau via GitGitGadget, Mar 22, 2023
  8. Junio C HamanoMar 22, 2023
  9. Clement MabileauMar 23, 2023
  10. Clement MabileauApr 4, 2023
  11. Junio C HamanoApr 4, 2023
  12. Clement MabileauApr 5, 2023
  13. branch: improve error log on branch not found by checking remotes refsClementMabileau via GitGitGadget, Apr 5, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.