Re: [PATCH] ls-tree: default <tree-ish> to HEAD

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 7, 2023, 16:25 UTC
Message-ID: <xmqqmsz2hl9m.fsf@gitster.g>
In-Reply-To: <pull.1566.git.1691412557518.gitgitgadget@gmail.com>

"Ryan Williams via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 6 quoted lines

> From: Ryan Williams <ryan@runsascoded.com>
>
> When no positional arguments are passed to `git ls-tree`, it currently
> prints "usage" info to stderr and exits with code 129. A more intuitive
> default would be to operate on the `HEAD` commit's tree (similarly to
> `git show`, `git log`, and possibly others).

As 'ls-tree' is a plumbing command meant for script writers, it was designed to require the users to be more explicit. So, similarity to "show" and other Porcelain commands do not weigh much here. Same for "rev-list" that does not fall back to HEAD.

This was a very deliberate design decision to help use of the plumbing commands. A buggy script may say

    TREE=$(some command to find a tree object)
    git ls-tree $TREE

without making sure something sensible is in $TREE (and not even quoting it like "$TREE"), and if ls-tree defaulted to something, the script will silently produce a wrong result, instead of failing, robbing the script writer a chance to notice a bug in their code to come up with the TREE object name.

So, I dunno.

Thanks.