Re: [PATCH v5 0/2] Implement `git log --merge` also for rebase/cherry-pick/revert

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2024, 18:30 UTC
Message-ID: <xmqqmsrlsqty.fsf@gitster.g>
In-Reply-To: <ff5a3954-4e7a-42b7-988e-f306b45918bf@gmail.com>

Phillip Wood <phillip.wood123@gmail.com> writes:

Show 16 quoted lines

> On 25/02/2024 21:56, Philippe Blain wrote:
>> Changes in v5:
>> - Marked error messages for translation and tweaked them as suggested by Phillip
>> - Reworded the message of 2/2 as suggested by Phillip
>> - Removed the change to gitk's doc in 2/2 as pointed out by Johannes
>> - Fixed the trailers in 2/2
>> - Improved the doc in 2/2 as suggested by Phillip and Jean-Noël
>
> These changes look good, thanks for making them. I agree with the
> other reviewers that it would be nice to improve the wording of the
> error message when we find a symbolic ref. Everything else looks good
> to me.
>
> Thanks
>
> Phillip

Thanks for a review.  Queued.