git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH] unit-tests: add tests for oidset.h

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 30, 2024, 18:48 UTC
Message-ID
<xmqqmsjp6kqb.fsf@gitster.g>
In-Reply-To
<ZveqArC9NNs44Fjc@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 28 quoted lines
> Let me use this to give a quick status update regarding my upstream
> quest to address the feedback I got during reviews on the clar itself:
>
>   - There is a .editorconfig file now.
>
>   - All the cross-platform compatibility fixes have been merged.
>
>   - We have Win32 wired up in CI. Doing so via Makefiles was too much of
>     a hassle, so I converted the project to use CMake for easier cross
>     platform testability. The fact that the project uses CMake does not
>     impact us though, as we wire it up ourselves anyway.
>
>   - All memory allocation errors are now handled consistently.
>
> Currently in review is:
>
>   - Self-tests for the clar, where we use clar to assert that clar
>     works.
>
>   - A small memory leak fix, as well as wiring up leak sanitizers in CI.
>
> I've also got a patch series sitting locally that introduces type-safe
> wrappers for the assertions that I'll move into review once self-tests
> have landed. That would then address the last bit of feedback I got, if
> I remember correctly.
>
> Just to let you folks know that I didn't just do nothing after this has
> landed in Git.
;-)

Nice to see that the code is improved not just for us but for other consumers.

Thanks.
Previous: Patrick Steinhardt
Message 10 of 10 in “unit-tests: add tests for oidset.h”
  1. Ghanshyam ThakkarAug 24, 2024
  2. Patrick SteinhardtAug 26, 2024
  3. Christian CouderAug 26, 2024
  4. Junio C HamanoAug 26, 2024
  5. Junio C HamanoSep 26, 2024
  6. howto-maintain-git: discarding inactive topicsJunio C Hamano, Sep 26, 2024
  7. Christian CouderSep 27, 2024
  8. Junio C HamanoSep 27, 2024
  9. Patrick SteinhardtSep 28, 2024
  10. Junio C HamanoSep 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.