Re: [PATCH 3/3] bulk-checkin: wire repository variable

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 21, 2025, 20:32 UTC
Message-ID: <xmqqms7sza95.fsf@gitster.g>
In-Reply-To: <rhkhmaozjaogm34xfwagagy2qifsq5p4fbtb23nhdu7jfg2627@qkrv57gg2k3u>

Justin Tobler <jltobler@gmail.com> writes:

> Thinking about this more, we should probably just require
> `index_blob_bulk_checkin()` be provided a transaction. Callers will need
> to ensure a transaction is running so that a `struct
> bulk_checkin_packfile` gets set up, but this shouldn't be a big deal.

Thanks for thinking this through. I think reducing the number of oddball callers-from-sideways leads us to good code hygiene.

Show 6 quoted lines

> With this we could easily just propagate the transaction for all these
> function as you suggested.
>
> I'll do this in the next version. Thanks!
>
> -Justin

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.