Re: [PATCH v3] MyFirstContribution: add note on confirming patches
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 27, 2025, 15:09 UTC
- Message-ID
- <xmqqms5cl6t8.fsf@gitster.g>
- In-Reply-To
- <20251027111600.1481-1-qjessa662@gmail.com>
QueenJcloud <qjessa662@gmail.com> writes:
Show 12 quoted lines
> Add a note after the `git send-email` section explaining how > contributors can confirm that their patches reached the mailing > list by checking https://lore.kernel.org/git/. This helps > contributors verify that their emails were successfully delivered. > > Signed-off-by: QueenJcloud <qjessa662@gmail.com> > --- > Changes since v2: > - Distinctive/correct name to the email > - Added changelog note after '---' > - Removed extra blank line at the end of the section > - No other text or formatting changes
OK. It is a bit unexpected that you have picked a less name-looking author identity (it is more common to use some form of your real name around here, as described in Documentation/SubmittingPatches), but that's OK.
Show 7 quoted lines
> --- > Documentation/MyFirstContribution.adoc | 6 ++- > ...bution-add-note-on-confirming-patche.patch | 39 ++++++++++++++++ > ...bution-add-note-on-confirming-patche.patch | 46 +++++++++++++++++++ > 3 files changed, 90 insertions(+), 1 deletion(-) > create mode 100644 v2-0001-MyFirstContribution-add-note-on-confirming-patche.patch > create mode 100644 v3-0001-MyFirstContribution-add-note-on-confirming-patche.patch
You didn't mean to add these patch files, I strongly suspect ;-)
Show 20 quoted lines
> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc > index 02ba8ba5f6..95f96b8451 100644 > --- a/Documentation/MyFirstContribution.adoc > +++ b/Documentation/MyFirstContribution.adoc > @@ -1153,11 +1153,15 @@ NOTE: When you are sending a real patch, it will go to git@vger.kernel.org - but > please don't send your patchset from the tutorial to the real mailing list! For > now, you can send it to yourself, to make sure you understand how it will look. > > +NOTE: After sending your patches, you can confirm that they reached the mailing > +list by visiting https://lore.kernel.org/git/. Use the search bar to find your > +name or the subject of your patch. If it appears, your email was successfully > +delivered. > + > After you run the command above, you will be presented with an interactive > prompt for each patch that's about to go out. This gives you one last chance to > edit or quit sending something (but again, don't edit code this way). Once you > press `y` or `a` at these prompts your emails will be sent! Congratulations! > - > Awesome, now the community will drop everything and review your changes. (Just > kidding - be patient!)
Will queue without these two extra files. Thanks.