Re: [PATCH v3] blame: make diff algorithm configurable
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 9 quoted lines
>> +static int blame_diff_algorithm_minimal(const struct option *option,
>> + const char *arg, int unset)
>> +{
>> + int *opt = option->value;
>> +
>> + BUG_ON_OPT_NEG(unset);
>
> This is a change in behavior as we currently accept "--no-minimal" which
> clears XDF_NEED_MINIMALAh, I missed this; thanks for a careful reading.
Show 12 quoted lines
> As I said above using PARSE_OPT_NONEG here is a regression
>
>> + blame_diff_algorithm_minimal),
>> diff --git a/t/t8015-blame-diff-algorithm.sh b/t/t8015-blame-diff-algorithm.sh
>> new file mode 100755
>> index 0000000000..efc4b47ce1
>> --- /dev/null
>> +++ b/t/t8015-blame-diff-algorithm.sh
>> [...]
>> +test_expect_success 'blame uses Myers diff algorithm by default for now' '
>
> I'm not sure we need to say "for now" here.
Junio C Hamano <gitster@pobox.com>