git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 09/10] tree: stop using the_repository

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 12, 2026, 15:20 UTC
Message-ID
<xmqqms2in9hb.fsf@gitster.g>
In-Reply-To
<aWUMn6G0C1cHA4qY@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 11 quoted lines
>> > In any case, I'd propose to move the compatibility macros into a section
>> > that says something like:
>> >
>> >     /* Deprecated wrappers that will be removed once Git 2.53 is released. */
>> 
>> Please do not take release schedule hostage to one particular fix-up
>> series of patches.  Thanks.
>
> The intent isn't really to take anything hostage. It's rather intended
> as a hint that once a specific event has happened, we should take
> another look at removing these wrappers.

I am OK with a comment that records the intent, e.g., "let's work towards reducing the use of these wrappers", with the plan for the next step, e.g., "and once we have done so, remove these."

But the comment you wrote is forcing people to make sure we remove the code that uses these wrappers and unless we finish it we cannot release 2.53, no?

Previous: Junio C HamanoNext: Patrick Steinhardt
Message 11 of 25 in “tree: stop using the_repository”
  1. 00/10 tree: stop using the_repositoryRené Scharfe, Jan 9, 2026
  2. 03/10 add-interactive: use repo_parse_tree_indirect()René Scharfe, Jan 9, 2026
  3. 04/10 bloom: use repo_parse_tree()René Scharfe, Jan 9, 2026
  4. 08/10 tree: use repo_parse_tree()René Scharfe, Jan 9, 2026
  5. Patrick SteinhardtJan 12, 2026
  6. 09/10 tree: stop using the_repositoryRené Scharfe, Jan 9, 2026
  7. Patrick SteinhardtJan 12, 2026
  8. Junio C HamanoJan 12, 2026
  9. Patrick SteinhardtJan 12, 2026
  10. Junio C HamanoJan 12, 2026
  11. Junio C HamanoJan 12, 2026
  12. Patrick SteinhardtJan 12, 2026
  13. René ScharfeJan 12, 2026
  14. Patrick SteinhardtJan 13, 2026
  15. 10/10 cocci: convert parse_tree functions to repo_ variantsRené Scharfe, Jan 9, 2026
  16. 02/10 tree: add repo_parse_tree*()René Scharfe, Jan 9, 2026
  17. 01/10 environment: move access to core.maxTreeDepth into repo settingsRené Scharfe, Jan 9, 2026
  18. Patrick SteinhardtJan 12, 2026
  19. René ScharfeJan 12, 2026
  20. 07/10 path-walk: use repo_parse_tree_gently()René Scharfe, Jan 9, 2026
  21. 05/10 delta-islands: use repo_parse_tree()René Scharfe, Jan 9, 2026
  22. 06/10 pack-bitmap-write: use repo_parse_tree()René Scharfe, Jan 9, 2026
  23. 11/10 cocci: remove obsolete the_repository rulesRené Scharfe, Jan 15, 2026
  24. Patrick SteinhardtJan 16, 2026
  25. Junio C HamanoJan 16, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.