Re: [PATCH] send-email: pass smtp hostname and port to Authen::SASL

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 5, 2026, 16:24 UTC
Message-ID: <xmqqms0m452i.fsf@gitster.g>
In-Reply-To: <MAUPR01MB115467BA486F4F9B4E6829D64B87DA@MAUPR01MB11546.INDPRD01.PROD.OUTLOOK.COM>

Aditya Garg <gargaditya08@live.com> writes:

Show 12 quoted lines

>> On 5 Mar 2026, at 8:15 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> Aditya Garg <gargaditya08@live.com> writes:
>> 
>> [administrivia]
>> 
>>    Please do not send patch e-mails directly at me, unless you know
>>    that I am the area authority.  Initial submissions are better
>>    sent to the list on To: list, with area experts on Cc: if you
>>    know or found out who they are.
>
> Oh sorry. I just did whatever I did in my previous contributions. I didn't know the rules changed.

No rule changes as far as I know.

Show 17 quoted lines

>>> Starting from version 2.2000, Authen::SASL supports passing the SMTP
>>> server hostname and port to the OAUTHBEARER string passed via SMTP AUTH.
>>> Add support for the same in git-send-email.
>> 
>> The proposed log message should answer these questions as well:
>> 
>>   What happens with version before 2.2000?  Is it safe to
>>   unconditionally add parameters like this patch does, and why?
>
> It's safe to add parameters unconditionally because the library
> will simply reject them without any error. It's basically like
> declaring a variable and not using it anywhere for older
> versions. I have tested this with old libraries as well.
>
> Consider the fact that the authname variable is also not in every
> authentication method used by Authen SASL, still its declared
> unconditionally before.

These are good to have in the proposed log message.

Thanks.